Skip to content

util: eliminate unecessary internal/util export #11455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jasnell wants to merge 1 commit into from
Closed

util: eliminate unecessary internal/util export #11455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
util: eliminate unecessary internal/util export 
The objectToString method was only being used in one place
within internalUtil. It didn't make sense to have it as
a separate exported mnethod.
  • Loading branch information
@jasnell
jasnell committed Feb 18, 2017
commit 889e791d4b43e300b7a478d8712afdbcdca47326
7 changes: 2 additions & 5 deletions lib/internal/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,8 @@ exports.decorateErrorStack = function decorateErrorStack(err) {
};

exports.isError = function isError(e) {
return exports.objectToString(e) === '[object Error]' || e instanceof Error;
};

exports.objectToString = function objectToString(o) {
return Object.prototype.toString.call(o);
return Object.prototype.toString.call(e) === '[object Error]' ||
e instanceof Error;
};

const noCrypto = !process.versions.openssl;
Expand Down