Skip to content

src,test: Prepare for future V8 changes #11437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
targos merged 2 commits into from
Feb 19, 2017
Merged

src,test: Prepare for future V8 changes #11437

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99b75fa
src: remove usage of deprecated debug API
hashseed Feb 2, 2017
751404d
test: fix over-dependence on native promise impl
ofrobots Jan 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: fix over-dependence on native promise impl 
In later versions of V8, the stack trace will be different than our
current expectations for Promise methods.

PR-URL: #11437
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
@ofrobots @targos
ofrobots authored and targos committed Feb 19, 2017
commit 751404dc287e9d404a7186d73684e97fabbe3064
4 changes: 2 additions & 2 deletions test/message/unhandled_promise_trace_warnings.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@
at getAsynchronousRejectionWarningObject (internal/process/promises.js:*)
at rejectionHandled (internal/process/promises.js:*)
at *
at Promise.then (native)
at Promise.catch (native)
at Promise.then *
at Promise.catch *
at Immediate.setImmediate (*test*message*unhandled_promise_trace_warnings.js:*)
at *
at *
Expand Down