Skip to content

src: fix v8 local handling in node_url.cc #11064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 1 commit into from
Closed

src: fix v8 local handling in node_url.cc #11064

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: fix v8 local handling in node_url.cc 
Calling `.As<Object>()` on a non-object aborts in debug mode,
but `node_url.cc` relied on it. Address that by using `Local<Value>`
until it has been confirmed that the handle actually is an object.
  • Loading branch information
@addaleax
addaleax committed Jan 29, 2017
commit c02f8ec09cdb65cddf0d3a5bed29578741b5084d
12 changes: 6 additions & 6 deletions src/node_url.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,8 +636,8 @@ namespace url {
const char* input,
const size_t len,
enum url_parse_state override,
Local<Object> base_obj,
Local<Object> context_obj,
Local<Value> base_obj,
Local<Value> context_obj,
Local<Function> cb) {
Isolate* isolate = env->isolate();
Local<Context> context = env->context();
Expand All @@ -654,9 +654,9 @@ namespace url {
struct url_data base;
struct url_data url;
if (context_obj->IsObject())
HarvestContext(env, &url, context_obj);
HarvestContext(env, &url, context_obj.As<Object>());
if (has_base)
HarvestBase(env, &base, base_obj);
HarvestBase(env, &base, base_obj.As<Object>());

std::string buffer;
url.scheme.reserve(len);
Expand Down Expand Up @@ -1321,8 +1321,8 @@ namespace url {
Parse(env, args.This(),
*input, input.length(),
override,
args[2].As<Object>(),
args[3].As<Object>(),
args[2],
args[3],
args[4].As<Function>());
}

Expand Down