Skip to content

v7.x: backport update to V8 5.5 #11029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
targos merged 8 commits into from
Feb 7, 2017
Merged

v7.x: backport update to V8 5.5 #11029

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c1acc22
deps: update V8 to 5.5.372.40
targos Feb 1, 2017
a6715e5
deps: cherry-pick workaround for clang-3.4 ICE
targos Sep 12, 2016
0ad61b6
deps: limit regress/regress-crbug-514081 v8 test
mhdawson May 9, 2016
b8c078a
test: move test-vm-function-redefinition to parallel
fhinkel Sep 16, 2016
ce020fb
repl: remove workaround for function redefinition
targos Dec 3, 2016
85f45cc
deps: ensure V8 5.4 ABI compatibility
targos Sep 29, 2016
1d55b34
deps: revert breaking UTF-8 decoder changes in V8
targos Jan 26, 2017
fd04af1
deps: work around SmartOS 14 incompatibility
targos Jan 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: cherry-pick workaround for clang-3.4 ICE 
Fixes: #8323
Refs: #8343
Refs: #8317

PR-URL: #11029
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
  • Loading branch information
@targos
targos committed Feb 7, 2017
commit a6715e57e3b8b28e93a7c462dd31cd0cbc0441b2
14 changes: 12 additions & 2 deletions deps/v8/src/heap/mark-compact.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3673,10 +3673,20 @@ int NumberOfPointerUpdateTasks(int pages) {

template <PointerDirection direction>
void UpdatePointersInParallel(Heap* heap, base::Semaphore* semaphore) {
// Work-around bug in clang-3.4
// https://github.com/nodejs/node/issues/8323
struct MemoryChunkVisitor {
PageParallelJob<PointerUpdateJobTraits<direction> >& job_;
MemoryChunkVisitor(PageParallelJob<PointerUpdateJobTraits<direction> >& job)
: job_(job) {}
void operator()(MemoryChunk* chunk) {
job_.AddPage(chunk, 0);
}
};

PageParallelJob<PointerUpdateJobTraits<direction> > job(
heap, heap->isolate()->cancelable_task_manager(), semaphore);
RememberedSet<direction>::IterateMemoryChunks(
heap, [&job](MemoryChunk* chunk) { job.AddPage(chunk, 0); });
RememberedSet<direction>::IterateMemoryChunks(heap, MemoryChunkVisitor(job));
int num_pages = job.NumberOfPages();
int num_tasks = NumberOfPointerUpdateTasks(num_pages);
job.Run(num_tasks, [](int i) { return 0; });
Expand Down