Skip to content

url: check forEach callback is a function #10905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TimothyGu wants to merge 6 commits into from
Closed

url: check forEach callback is a function #10905

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f0f65de
url: add additional tests for URLSearchParams#forEach
TimothyGu Jan 15, 2017
44acced
url: check forEach callback is a function
TimothyGu Jan 15, 2017
182ce97
More specific error message tests
TimothyGu Jan 20, 2017
c6f5900
Remove obsolete arguments.length check in forEach()
TimothyGu Jan 20, 2017
6775629
Make argument check error messages consistent with rest of code base
TimothyGu Jan 20, 2017
593a0d9
Update error messages in test
TimothyGu Jan 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More specific error message tests
  • Loading branch information
@TimothyGu
TimothyGu committed Jan 20, 2017
commit 182ce97f3bfaf351d2c64a5f65415b2b68443b75
6 changes: 4 additions & 2 deletions test/parallel/test-whatwg-url-searchparams.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,10 @@ sp.forEach(function(val, key, obj) {
sp.forEach(function() {
assert.strictEqual(this, m);
}, m);
assert.throws(() => sp.forEach(), TypeError);
assert.throws(() => sp.forEach(1), TypeError);
assert.throws(() => sp.forEach(),
/^TypeError: The `callback` argument needs to be specified$/);
assert.throws(() => sp.forEach(1),
/^TypeError: The `callback` argument must be a function$/);

m.search = '?a=a&b=b';
assert.strictEqual(sp.toString(), 'a=a&b=b');