Skip to content

child_process: Allow an unlimited maxBuffer size in child_process #10767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jwdeitch wants to merge 1 commit into from
Closed

child_process: Allow an unlimited maxBuffer size in child_process #10767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Allow an unlimited maxBuffer size
  • Loading branch information
@jwdeitch
jwdeitch authored Jan 12, 2017
commit 210083c7ce4bd614b72b1f2f57bc72992ba2819b
2 changes: 1 addition & 1 deletion lib/child_process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ exports.execFile = function(file /*, args, options, callback*/) {
child.stdout.on('data', function onChildStdout(chunk) {
stdoutLen += encoding ? Buffer.byteLength(chunk, encoding) : chunk.length;

if (stdoutLen > options.maxBuffer) {
if (stdoutLen > options.maxBuffer && options.maxBuffer !== 0) {
ex = new Error('stdout maxBuffer exceeded');
kill();
} else {
Expand Down