Skip to content

src: describe what NODE_MODULE_VERSION is for #10414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sam-github wants to merge 1 commit into from
Closed

src: describe what NODE_MODULE_VERSION is for #10414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: describe what NODE_MODULE_VERSION is for 
Current comment described what to do with it when the ABI changes, but
implied that node would load modules with newer ABI numbers, which it
will not.
  • Loading branch information
@sam-github
sam-github committed Dec 22, 2016
commit 2f5b9a486556abcde8b1342c822f61aa76157009
3 changes: 3 additions & 0 deletions src/node_version.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@
(minor) == NODE_MINOR_VERSION && (patch) <= NODE_PATCH_VERSION))

/**
* Node.js will refuse to load modules that weren't compiled against its own
* module ABI number, exposed as the process.versions.modules property.
*
* When this version number is changed, node.js will refuse
* to load older modules. This should be done whenever
* an API is broken in the C++ side, including in v8 or
Expand Down