Skip to content

test: refactor test-crypto-random #10232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

test: refactor test-crypto-random #10232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: refactor test-crypto-random 
* specify constructor for assert.throws()
* load additional modules only if crypto check passes
* normalize some potentially confusing indentation
* provided actual first and expected second in assertions
  • Loading branch information
@Trott
Trott committed Dec 12, 2016
commit 6b6021de30b73a9393921f468ce838b63f8619c4
23 changes: 7 additions & 16 deletions test/parallel/test-crypto-random.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,28 @@
'use strict';
const common = require('../common');
const assert = require('assert');

if (!common.hasCrypto) {
common.skip('missing crypto');
return;
}
const assert = require('assert');
const crypto = require('crypto');

crypto.DEFAULT_ENCODING = 'buffer';

// bump, we register a lot of exit listeners
process.setMaxListeners(256);

[crypto.randomBytes,
crypto.pseudoRandomBytes
].forEach(function(f) {
[-1,
undefined,
null,
false,
true,
{},
[]
].forEach(function(value) {
assert.throws(function() { f(value); });
assert.throws(function() { f(value, function() {}); });
[crypto.randomBytes, crypto.pseudoRandomBytes].forEach(function(f) {
[-1, undefined, null, false, true, {}, []].forEach(function(value) {
assert.throws(function() { f(value); }, TypeError);
assert.throws(function() { f(value, function() {}); }, TypeError);
});

[0, 1, 2, 4, 16, 256, 1024].forEach(function(len) {
f(len, common.mustCall(function(ex, buf) {
assert.strictEqual(null, ex);
assert.strictEqual(len, buf.length);
assert.strictEqual(ex, null);
assert.strictEqual(buf.length, len);
assert.ok(Buffer.isBuffer(buf));
}));
});
Expand Down