Skip to content

test: check for error on invalid signal #10026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattcphillips wants to merge 1 commit into from
Closed

test: check for error on invalid signal #10026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: check for error on invalid signal 
Asserts that an error should be thrown when
an invalid signal is passed to process.kill
  • Loading branch information
@mattcphillips
mattcphillips committed Dec 4, 2016
commit 5fdea9d97139370d207a24d9258e8fefb45e5924
4 changes: 4 additions & 0 deletions test/parallel/test-process-kill-pid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ assert.throws(function() { process.kill(+'not a number'); }, TypeError);
assert.throws(function() { process.kill(1 / 0); }, TypeError);
assert.throws(function() { process.kill(-1 / 0); }, TypeError);

// Test that kill throws an error for invalid signal

assert.throws(function() { process.kill(1, 'test'); }, Error);

@jasnell jasnell Dec 5, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok but passing a regexp as the second argument would be better.

assert.throws(() => {
  process.kill(1, 'test');
}, /^Error: Unknown signal: test$/);


// Test kill argument processing in valid cases.
//
// Monkey patch _kill so that we don't actually send any signals, particularly
Expand Down