chore: test removeLabel

This was the last GitHub API call not covered by our tests.
mmarchini · Aug 20, 2020 · Aug 15, 2020 · Aug 15, 2020 · Aug 15, 2020 · Aug 15, 2020
commit 948ee8229fc83c23da722eb2e3f4f35dc36bf7a0
diff --git a/lib/node-repo.js b/lib/node-repo.js
@@ -83,10 +83,10 @@ async function updatePrWithLabels (options, labels) {
   }
 }
 
-function removeLabelFromPR (options, label) {
+function removeLabelFromPR (options, label, cb) {
   // no need to request github if we didn't resolve a label
   if (!label) {
-    return
+    return cb()
   }
 
   options.logger.debug('Trying to remove label: ' + label)
@@ -99,11 +99,12 @@ function removeLabelFromPR (options, label) {
   }, (err) => {
     if (err) {
       if (err.code === 404) return options.logger.info('Label to remove did not exist, bailing ' + label)
-
-      return options.logger.error(err, 'Error while removing a label')
+      options.logger.error(err, 'Error while removing a label')
+      return cb(err, null)
     }
 
     options.logger.info('Removed a label ' + label)
+    return cb(null, label)
   })
 }
 

diff --git a/test/unit/node-repo.test.js b/test/unit/node-repo.test.js
@@ -133,3 +133,21 @@ tap.test('getBotPrLabels(): returns net labels added/removed by nodejs-github-bo
     scope.done()
   })
 })
+
+tap.test('removeLabelFromPR(): should remove label', (t) => {
+  const owner = 'nodejs'
+  const repo = 'node7'
+  const prId = '3'
+  const label = '3'
+
+  const scope = nock('https://api.github.com')
+    .filteringPath(ignoreQueryParams)
+    .delete(`/repos/${owner}/${repo}/issues/${prId}/labels/${label}`)
+    .reply(200)
+  t.plan(1)
+
+  nodeRepo.removeLabelFromPR({ owner, repo, prId, logger }, label, (_, response) => {
+    t.same(label, response)
+    scope.done()
+  })
+})