Skip to content

Post CI comment in PR for node-test-pull-request builds #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phillipj merged 3 commits into from
Mar 25, 2019
Merged

Post CI comment in PR for node-test-pull-request builds #224

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fd57ce8
jenkins: post CI comment in PR for node-test-pull-request builds
phillipj Mar 21, 2019
f4d73f5
jenkins: ensure job status === pending before posting CI comment
phillipj Mar 24, 2019
6f53aea
jenkins: move HTTP assertions from .tearDown() alongside response test
phillipj Mar 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
jenkins: move HTTP assertions from .tearDown() alongside response test 
As it's way more intuitive to have those outgoing HTTP request
assertions alongside other assertions, than as part of the test tear
down process.
  • Loading branch information
@phillipj
phillipj committed Mar 24, 2019
commit 6f53aeab47a0b82aa2caa536f1632d77118dc7f7
2 changes: 1 addition & 1 deletion test/integration/push-jenkins-update.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,13 +117,13 @@ tap.test('Posts a CI comment in the related PR when Jenkins build is named node-
.reply(201)

t.plan(1)
t.tearDown(() => commentScope.done())

supertest(app)
.post('/node/jenkins/start')
.send(fixture)
.expect(201)
.end((err, res) => {
commentScope.done()
t.equal(err, null)
})
})
Expand Down