Skip to content

Refactor of the cmd.js - Still a WIP, but looking for comments #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lholmquist wants to merge 7 commits into from
Closed

Refactor of the cmd.js - Still a WIP, but looking for comments #73

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e95c89f
squash: adding some comments
lholmquist Jul 19, 2019
d5dc539
squash: move the list-subsytem command up
lholmquist Jul 23, 2019
2254e65
squash: moving the load and loadPatch functions util
lholmquist Jul 23, 2019
b4949d0
squash: Adding tests in for load and loadPatch
lholmquist Jul 25, 2019
5d8f5ca
squash: moving validate-metadata
lholmquist Jul 23, 2019
b31953f
squash: move the tap logic to util
lholmquist Jul 25, 2019
28f321e
squash: add callback function
lholmquist Jul 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
squash: adding some comments 
squash: add more comments

squash: add more comments
  • Loading branch information
@lholmquist
lholmquist committed Jul 25, 2019
commit e95c89fc64b26e003ab417ded5b5b0c5dde3d028
23 changes: 22 additions & 1 deletion bin/cmd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,19 +35,28 @@ const shortHand = { h: ['--help']
const parsed = nopt(knownOpts, shortHand)
const usage = require('help')()

// The --help or -h flag was used
if (parsed.help) {
return usage()
}

// The --version or -v flag was used
if (parsed.version) {
console.log('core-validate-commit', 'v' + require('../package').version)
return
}

// any arguments after a --flag will be in the remain array
const args = parsed.argv.remain

// The argument should be the commit you are validating
// If there is no args, then use the HEAD commit
if (!args.length)
args.push('HEAD')

// Given a commit hash, load it
// If a URL is passed in, then load the commit remotely
// If not, then do a git show
function load(sha, cb) {
const parsed = url.parse(sha)
if (parsed.protocol) {
Expand All @@ -60,6 +69,7 @@ function load(sha, cb) {
})
}

// Load the commit from a URL
function loadPatch(uri, cb) {
let h = http
if (~uri.protocol.indexOf('https')) {
Expand All @@ -85,26 +95,36 @@ function loadPatch(uri, cb) {
}).on('error', cb)
}

// Create a new Validator
const v = new Validator(parsed)

// The --list-subsytems or --ls flag was used
if (parsed['list-subsystems']) {
utils.describeSubsystem(subsystem.defaults.subsystems.sort())
return
}

// The --list or -l flag was used
if (parsed.list) {
// Get the list of Rule names
// There is nothing here that says we need to have created that validator first,
// unless at some point we don't count disabled things
// But we should probably just get the rules from the rules in ./lib/rules
// Then this function can move up to the top
const ruleNames = Array.from(v.rules.keys())
// Find the length of the longest Rule names
const max = ruleNames.reduce((m, item) => {
if (item.length > m) m = item.length
return m
}, 0)

// Loop through and output the rules
for (const rule of v.rules.values()) {
utils.describeRule(rule, max)
}
return
}

// The --tap or -t flag was used
if (parsed.tap) {
const tap = new Tap()
tap.pipe(process.stdout)
Expand Down Expand Up @@ -138,6 +158,7 @@ if (parsed.tap) {
run()

} else {
// no --flags used, defaults to --validate-metadata
v.on('commit', (c) => {
pretty(c.commit, c.messages, v)
run()
Expand Down