Skip to content

Ensures that commits from parent(*) has a repository #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
implausible merged 1 commit into from
Apr 17, 2019
Merged

Ensures that commits from parent(*) has a repository #1658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Ensures that commits from parent(*) has a repository 
Commit has functions that requires a reference to a repository to run.
Because parent(*) was simply calling out to libgit2's
git_commit_parent directly, its repo field was not being set. Creating
a wrapper in the Commit class and assigning a repository to the object
before returning it will fix this problem.

Signed-off-by: Remy Suen <remy.suen@gmail.com>
  • Loading branch information
@rcjsuen
rcjsuen committed Apr 10, 2019
commit a929d38364de3dfe4284b0f83e2fc00dd30d00a7
16 changes: 16 additions & 0 deletions lib/commit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ var Commit = NodeGit.Commit;
var LookupWrapper = NodeGit.Utils.lookupWrapper;

var _amend = Commit.prototype.amend;
var _parent = Commit.prototype.parent;

/**
* Retrieves the commit pointed to by the oid
Expand Down Expand Up @@ -394,6 +395,21 @@ Commit.prototype.history = function() {
return event;
};

/**
* Get the specified parent of the commit.
*
* @param {number} the position of the parent, starting from 0
* @async
* @return {Commit} the parent commit at the specified position
*/
Commit.prototype.parent = function (id) {
var repository = this.repo;
return _parent.call(this, id).then(function(parent) {
parent.repo = repository;
return parent;
});
};

/**
* Retrieve the commit's parent shas.
*
Expand Down
12 changes: 12 additions & 0 deletions test/tests/commit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,18 @@ describe("Commit", function() {
assert.equal(this.commit.timeOffset(), 780);
});

it("can call getTree on a parent commit", function() {
return this.commit.parent(0)
.then(function(parent) {
return parent.getTree();
})
.then(function(tree) {
assert.equal(
tree.id().toString(), "327ff68e59f94f0c25d2c62fb0938efa01e8a107"
);
});
});

it("can create a commit", function() {
var test = this;
var expectedCommitId = "315e77328ef596f3bc065d8ac6dd2c72c09de8a5";
Expand Down