Skip to content

Adding git_filter support in nodegit #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
implausible merged 9 commits into from
Aug 1, 2017
Merged

Adding git_filter support in nodegit #1331

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4e34797
Adding filters to generator template
mohseenrm Jun 1, 2017
f4f7a4d
Adding Filter registration, clean build, passing test
mohseenrm Jun 6, 2017
3844f98
Added Filter callback support
mohseenrm Jun 9, 2017
172e4ad
Transition to manual templates
mohseenrm Jun 19, 2017
60c1866
Added Async functionality
mohseenrm Jun 26, 2017
339799e
Added more unit tests
mohseenrm Jul 6, 2017
718e101
Fixed field_accessors template
Jul 11, 2017
8c6d2a5
Fixing rouge console logs and bugs in tests
mohseenrm Jul 12, 2017
debcf21
Updating with requested changes and refactors
mohseenrm Jul 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed field_accessors template
  • Loading branch information
Carson Howard @mohseenrm
Carson Howard authored and mohseenrm committed Jul 25, 2017
commit 718e101eb2d1f6166963b422b406c97e945cb2e7
1 change: 0 additions & 1 deletion generate/templates/partials/async_function.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ NAN_METHOD({{ cppClassName }}::{{ cppFunctionName }}) {
{%elsif arg.shouldAlloc %}
{%if arg.cppClassName == "GitBuf" %}
{%else%}
// culprit found
baton->{{ arg.name }} = ({{ arg.cType }})malloc(sizeof({{ arg.cType|replace '*' '' }}));
{%endif%}
{%endif%}
Expand Down
21 changes: 15 additions & 6 deletions generate/templates/partials/field_accessors.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,8 @@
{% if not arg.firstArg %}
{% if field.args|jsArgsCount|subtract 1|or 0 %}
{% if arg.cppClassName == "String" %}
src,
{%-- src is always the last arg --%}
src
{% elsif arg.isJsArg %}
{% if arg.isEnum %}
Nan::New((int)baton->{{ arg.name }}),
Expand All @@ -224,15 +225,17 @@
{% elsif arg.cType == "size_t" %}
Nan::New((unsigned int)baton->{{ arg.name }}),
{% elsif arg.name == "payload" %}
{%-- skip, filters should not have a payload --%}
{% else %}
Nan::New(baton->{{ arg.name }}),
{% endif %}
{% endif %}
{% endif %}
{% endif %}
{% else %}
{% if arg.cppClassName == "String" %}
Nan::New(baton->{{ arg.name }}).ToLocalChecked(),
{% if arg.name == "payload" %}
{%-- payload is always the last arg --%}
Nan::New(instance->{{ fields|payloadFor field.name }})
{% elsif arg.isJsArg %}
{% if arg.isEnum %}
Nan::New((int)baton->{{ arg.name }}),
Expand All @@ -241,7 +244,8 @@
{% elsif arg.cType == "size_t" %}
// HACK: NAN should really have an overload for Nan::New to support size_t
Nan::New((unsigned int)baton->{{ arg.name }}),
{% elsif arg.name == "payload" %}
{% elsif arg.cppClassName == "String" %}
Nan::New(baton->{{ arg.name }}).ToLocalChecked(),
{% else %}
Nan::New(baton->{{ arg.name }}),
{% endif %}
Expand All @@ -255,12 +259,17 @@
{% endif %}

Nan::TryCatch tryCatch;
v8::Local<v8::Value> result = instance->{{ field.name }}.GetCallback()->Call({{ field.args|jsArgsCount|subtract 2| setUnsigned }}, argv);

{% if field.isSelfReferential %}
v8::Local<v8::Value> result = instance->{{ field.name }}.GetCallback()->Call({{ field.args|jsArgsCount|subtract 2| setUnsigned }}, argv);
{% else %}
v8::Local<v8::Value> result = instance->{{ field.name }}.GetCallback()->Call({{ field.args|jsArgsCount }}, argv);
{% endif %}

if(PromiseCompletion::ForwardIfPromise(result, baton, {{ cppClassName }}::{{ field.name }}_promiseCompleted)) {
return;
}
//TODO: fix for void cases

{% if field.return.type == "void" %}
baton->Done();
{% else %}
Expand Down