Repository navigation
Add more platforms to the setup #1362
Description
Heya guys.
At @inexorgame we are starting to rely heavily on nodegit
Is there any way that more platforms will be supported in the future by nodegit?
As far as I can tell, Docker could be used with a set of base images just to do that easily.
Activity
rcjsuen commentedon Aug 30, 2017
@Fohlen When you say "more platforms", what are you referring to exactly? More operating systems (say NetBSD and OpenBSD)? More Linux distributions? More versions of existing supported operating systems?
How can Docker images be used to easily do this?
saper commentedon Aug 30, 2017
@Fohlen Docker will not help whenever a different kernel is required.
Fohlen commentedon Aug 31, 2017
Firstly, I apologize for the rather vague ticket description.
@rcjsuen with more platforms, in specifically, I imagine:
Node.js(newer ones, if possible)npm(the 5 series in particular)Over at @inexorgame we use a combination of traditional bash scripts and Docker with different base images to build the same thing under different platforms. This approach may be comfortable for
nodegit, or may not.Commenting on @saper, this is true. OpenBSD/NetBSD might be needed to be build on some private Jenkins, if there is enough user demand.
If necessary, I think we can also add some templates in a PR, maybe they come in handy.
rcjsuen commentedon Aug 31, 2017
@Fohlen I guess when you say "the setup" you mean for the NodeGit binaries to be available via installation from npm without having to manually compile NodeGit, correct?
From looking at the latest builds, we do currently build on Node 8.4.0 and npm 5.3.0 on Travis CI and Node 8.3.0 and npm 5.3.0 on AppVeyor. It seems like Travis CI is building on OS X El Captain (and not macOS Sierra). It seems you have to either use Windows Server 2012 R2 or Windows Server 2016 on AppVeyor so there's not much we can do there I think?
As for Cent OS and Arch Linux, there are several open issues about those two (as well as other) Linux distributions so the demand is certainly there.
rsmarples commentedon Sep 29, 2017
There are some outstanding pull requests for better BSD platform support - namely #1237, #1344 and #1374.
With these changes, nodegit compiles at least on modern BSD platforms and I can vouch for NetBSD.
Fohlen commentedon Oct 22, 2017
I have to report that according to our CI only
Node 6.11.4, 7.10.1onUbuntu Trusty,OSXandWindowsare supported.We tested a couple more of platforms but as it seems currently
Node >7and other distros thanTrustyare unsupported.Fohlen commentedon Nov 5, 2017
https://github.com/nodegit/nodegit/blob/master/.travis.yml#L17
What's the issue here to:
As for the Windows and OSX support, there should be more node versions covered as well. Anyhow, nvm and windows-nvm can easily be used here..
Croydon commentedon Jul 27, 2018
I guess this can be closed in favor of #1298
Fohlen commentedon Jan 15, 2019
I will be closing this. It is insane that such a huge project does not build for the
LTSversion of node.rcjsuen commentedon Jan 15, 2019
@Fohlen NodeGit currently builts for Node.js v6, v8, and v10.
nodegit/.travis.yml
Lines 23 to 26 in 1bc53bf