Skip to content

N-API support for nodegit #1298

Open
Open

Description

@digitalinfinity

Hello! The recently announced Node 8 has a new experimental feature called N-API which is aimed at reducing maintenance cost for node native addons.

Check out this blog for more details on its benefits.

nodegit is one of the top 30 native modules by download dependency count, and in order to help the Node.js community make the important transition to N-API, we are hoping you will be able to work with us in order to port nodegit to support N-API. Your support and feedback is important in making this effort a success.
I am part of the N-API working group and would like to talk to you about how you can get started with N-API and how we can help. I'm available to talk on the phone individually if you'd like. Alternatively, if you prefer, feel free to jump in our WG meeting, which happens every Thursday at 1.30 Eastern/10.30 Pacific US time, to discuss any issues.

Here’s a video of N-API in action
https://www.youtube.com/watch?v=nmXhJ88nZsk

Activity

  1. tbranyen commented on Jun 8, 2017

    @tbranyen
    Member

    Darn I missed the WG meeting today, I'll catch it next week!

  2. digitalinfinity commented on Jun 8, 2017

    @digitalinfinity
    Author
  3. digitalinfinity commented on Jun 28, 2017

    @digitalinfinity
    Author

    Hi @tbranyen - there is a WG meeting planned for tomorrow at 10:30 AM PDT (5:30 PM UTC)- the hangout link is still the same - we'd love to have you join in, the members of the WG would be happy to answer any questions you might have on N-API.

  4. tbranyen commented on Jun 28, 2017

    @tbranyen
    Member

    @digitalinfinity I've been finding it hard to get time for this. Tomorrow I have either jury duty or I'm out sailing w/ my team (really hoping they don't call me in to court). I will do my best to try and get next Thursday available.

    @johnhaley81 by any chance do you have time to attend tomorrow in my place?

  5. maxkorp commented on Jun 28, 2017

    @maxkorp
    Collaborator

    @tbranyen @johnhaley81 I canhop in if needed.

  6. digitalinfinity commented on Jun 28, 2017

    @digitalinfinity
    Author

    all are welcome 😄 - @tbranyen @maxkorp @johnhaley81 we can also schedule a special one-off hangout with nodegit maintainers based on your availability to answer any questions you may have on N-API too, if that's more convenient

  7. maxkorp commented on Jun 28, 2017

    @maxkorp
    Collaborator

    I'll hop in the WG for sure 👍

  8. digitalinfinity commented on Jun 28, 2017

    @digitalinfinity
    Author

    @maxkorp awesome! looking forward to meeting you- if you have any issues with joining the hangout, let me know here on this thread and we'll try and unblock you

  9. maxkorp commented on Jun 29, 2017

    @maxkorp
    Collaborator

    I got meetinged and wasn't able to make it 😦. I'll have some time this weekend to start taking a look at this more in depth though.

  10. digitalinfinity commented on Jun 29, 2017

    @digitalinfinity
    Author

    No worries! Let us know if you have any questions, and if y'all want to schedule a separate call with WG members, that offer still stands 😄

  11. maxkorp commented on Jun 29, 2017

    @maxkorp
    Collaborator

    Awesome, thanks!

  12. johnhaley81 commented on Jul 3, 2017

    @johnhaley81
    Collaborator

    Hey guys, sorry I've been pretty unresponsive as of late. When is the next meeting?

  13. johnhaley81 commented on Jul 3, 2017

    @johnhaley81
    Collaborator

    If I just read the first message again...

    Alternatively, if you prefer, feel free to jump in our WG meeting, which happens every Thursday at 1.30 Eastern/10.30 Pacific US time, to discuss any issues.

    This is still the same? Same hangouts link?

  14. digitalinfinity commented on Jul 3, 2017

    @digitalinfinity
    Author
  15. johnhaley81 commented on Jul 6, 2017

    @johnhaley81
    Collaborator

    A quick summary of the Hangouts:

    During migration to N-API any issues can be opened at https://github.com/nodejs/abi-stable-node
    The C++ Wrapper package can be found at: https://github.com/nodejs/node-addon-api
    The documentation for N-API in node is at: https://nodejs.org/dist/latest-v8.x/docs/api/n-api.html

    Currently there is no support for Electron but it's in the early stages. There is also no support for node v6 but that is also a possibility after the API stabilizes. node-pre-gyp is also not supported yet but it's now noted that it's a big issue for NodeGit to fully migrate.

    Before these are solved the N-API version will have to live on a different branch since these are blocking issues.

    I'll try to start some preliminary work on this to see what the scope of the migration will be, what API's are missing and are needed by NodeGit and document the experience.

  16. a-teammate commented on Apr 26, 2018

    @a-teammate

    I'd like to add here, that with node.js 10 the N-API is no longer considered experimental :)
    Changelog

    How do you plan to do the transition? Is it something you want to achieve in one of the next milestones or how much priority does this have to you?

  17. implausible commented on Jan 31, 2019

    @implausible
    Member

    We should probably get around to this sometime this year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions