Rrule schedules - #540
Rrule schedules#540DinoEgo wants to merge 29 commits into
Conversation
|
If this might effect prioritization of reviewing this PR: having it merged would allow for support of use-case mentioned in #176 (comment) |
|
@DinoEgo Thank you for your contribution! Could you please pull latest changes from master in? |
|
@DinoEgo I'm planning to start breaking down the monolith of |
f1155b0 to
8f26adf
Compare
|
Not sure if I have rebased this correctly, please advise me if that is the case :) @kibertoad |
|
Im going to have to rework this due to the huge difference between master and dev, I will make a new PR and link it here |
7ad0759 to
99c7c1d
Compare
Yes, I was intending to do this as you asked earlier, but wanted to get the code in a state where is was working with master, then work from there to extract the rrule specific code. I have marked this PR as draft for now as there seems to be a lot more work that I need to do before this is ready for a re-review. Please feel free to add more comments to the existing code as you see fit |
|
@kibertoad Could you have a check over this, any comments you make I will review in the morning :) |
| const cronParser = require('cron-parser') | ||
| const CronDate = require('cron-parser/lib/date') | ||
| const sorted = require('sorted-array-functions') | ||
| const rruleUtil = require('./utils/rruleUtil'); |
There was a problem hiding this comment.
this should be dynamically required on the first attempt to add an rrule.
There was a problem hiding this comment.
As it is a utility, I disagree. Since we handle the missing dependency then we can include the util to sit and wait. Your call, let me know if I should change it
There was a problem hiding this comment.
I would rather see it not as merely a set of utility functions, but more like a module, almost a plugin, that should encapsulate as much of RRule functionality as possible, and should be as absent as possible if user does not opt in to use it.
|
Bump? its been 2 years :D |
3 participants
I have been using this library for a project and found that RRule support would be an easy and incredibly useful addition to have.