Skip to content

Introduce a PointerBuffer class for wrapping pointers #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TimothyJones wants to merge 11 commits into
base: latest
Choose a base branch
from
Open

Introduce a PointerBuffer class for wrapping pointers #64

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b2d32a8
Attempt to use pointer objects instead of buffers
nshmyrev May 6, 2021
7d1a4c8
Fix remaining string tests
nshmyrev May 8, 2021
d31acc6
Bump mocha
nshmyrev May 8, 2021
8a9d7b3
Add some missing int reading methods, more needed later
nshmyrev May 8, 2021
7490921
Fix argument order
nshmyrev May 8, 2021
cad53d2
Properly throw exceptions when value out of range
nshmyrev May 8, 2021
5f1f184
Merge remote-tracking branch 'upstream/latest' into latest
TimothyJones Oct 4, 2021
34e58cd
Bump version of node-addon-api
TimothyJones Oct 12, 2021
609d4f6
Try directly passing the finaliser to SetInstanceData to work around …
TimothyJones Oct 12, 2021
6401df0
Add node 16 to appveyor build
TimothyJones Oct 12, 2021
aed0caf
Remove devDependencies that were also listed in dependencies
TimothyJones Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix argument order
  • Loading branch information
@nshmyrev
nshmyrev committed May 8, 2021
commit 749092176c993b462fb6339df3c3c6d1ea9ff9d2
2 changes: 1 addition & 1 deletion lib/ref.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -930,7 +930,7 @@ types.int32 = {
return exports.readInt32(buf, offset || 0);
},
set: function set (buf, offset, val) {
return exports.writeInt32(buf, val, offset || 0);
return exports.writeInt32(buf, offset || 0, val);
}
}

Expand Down