Skip to content

build: remove unused @rollup/plugin-commonjs dependency - #616

Open
wojtekmaj wants to merge 1 commit into
node-cron:mainfrom
wojtekmaj:remove-rollup-plugin-commonjs
Open

wojtekmaj wants to merge 1 commit into
node-cron:mainfrom
wojtekmaj:remove-rollup-plugin-commonjs

Conversation

@wojtekmaj

Copy link
Copy Markdown
Contributor

@rollup/plugin-commonjs converts CommonJS input modules so Rollup can bundle them. node-cron's production sources are already ESM, it has no runtime dependencies, and Node built-ins are external, so the plugin has no input to transform.

The CommonJS bundle is produced by Rollup's format: "cjs" output setting and does not depend on this plugin.

This removes the plugin from the Rollup configuration and development dependencies. The generated ESM and CommonJS bundles, declarations, and source maps remain byte-for-byte identical.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant