Conversation
Contributor
Author
How I verified this4 commands recorded - as recorded (shortened, folded onto one line), grouped by kind. No entry asserts a pass or a fail: read the output. Not necessarily everything the session ran. test
Not verified: everything below is a limit of this section, listed whether or not it bit this attempt.
See the PR body's Evidence table for the orchestrator's own test run. |
Contributor
Author
Independent review — PASSED (2 rounds) on
|
| Severity | Finding | Where | Note |
|---|---|---|---|
| ✅ | funnel_eval red, unrelated to diff | — | Heads up that test_funnel_eval's process-group holdout test is red on this branch but green on base. Nothing in this diff goes near the eval harness or process- |
# Conflicts: # RELEASE_MANIFEST.txt
# Conflicts: # RELEASE_MANIFEST.txt
# Conflicts: # RELEASE_MANIFEST.txt
# Conflicts: # RELEASE_MANIFEST.txt # tests/test_structural_budget.py
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evidence
2 findings raised and addressed across review rounds
Verifiers (2)
1 failing test
tests/test_lane_conformance.py::test_the_js_implementation_agrees_on_every_shared_caseMerge-ready policy (6 rules, source: default)
Acceptance criteria
Changes
Final Report
Context: This attempt resumed a task where (a) the branch merge with base was already completed and committed (
b19ffb51), carrying forward the prior implementation of review-summary fetching, bot-comment classification, and the frozen-budget fix; and (b) a human/reviewer send-back identified one confirmed crash path in the new reviews block that needed a precisely-scoped fix.Root cause: In
fetch_github_pr_comments(src/no_human/vcs/pr_watcher.py), three separate loops usedx.get("user", {}).get("login").dict.get(key, default)only substitutes the default when the key is absent; GitHub sends"user": nullfor a review/comment whose author deleted their account — a present key with valueNone— so.get("user", {})still returnsNone, and.get("login")on it raisesAttributeError, uncaught, taking out the entire fetch (no line comments, no issue comments, no other reviews reach the caller).Fix (all in
src/no_human/vcs/pr_watcher.py, confirmed viagit diff):/pulls/{n}/comments):user = c.get("user") or {}, thenuser.get("login"/"type")./issues/{n}/comments): same pattern./pulls/{n}/reviews): same pattern — this is the block the send-back pointed at directly.Rest of the coder's report (7 more paragraphs)
Test added:
tests/test_pr_review_summaries.py::test_deleted_account_null_user_review_does_not_crash_the_fetch— uses a new fixture entryreviews.json[6]("user": null,CHANGES_REQUESTED, non-empty body). Verified as a genuine positive control: reverting just the reviews-block fix reproducesAttributeError: 'NoneType' object has no attribute 'get'at the exactr.get("user", {}).get("login")line; with the fix restored, all 13 tests in the file pass, and the fetch returns the null-user review (author="unknown", author_type="") plus the other reviews/line-comments/issue-comments unaffected.Non-blocking cleanup done: renamed
test_review_has_no_created_at_field→test_review_fixture_pins_no_created_at_fieldwith a docstring clarifying it only pins fixture shape and pointing at the actual behavioral test (test_review_at_or_before_the_cursor_is_not_fresh) forsubmitted_atcoverage.Evidence:
Positive-control check (reverted fix → test fails with the predicted
AttributeErrorat the exact line; restored fix → passes).(a paragraph matched a filtered-phrase list and was removed)
Diff scope this session:
src/no_human/vcs/pr_watcher.py,tests/fixtures/github_pr_reviews/reviews.json,tests/test_pr_review_summaries.py— nothing else touched;config.py/wake.py(frozen-budget files) untouched this session, matching the already-merged frozen pins (3697 / 2802 lines, both confirmed viawc -landtests/test_structural_budget.pypassing).src/no_human/vcs/pr_watcher.py:238-259(state filter + body-filter + PrComment emission);tests/test_pr_review_summaries.py:72-96(test_changes_requested_review_body_is_returned_as_feedback,test_commented_review_with_body_is_returned, `tes(summary truncated at 4000 characters — full report:
nh task show <task-id>)ignore_comment_authorsmechanism, extend it, or be implemented as a completely separate new setting? A: Implement as a separate new configuration setting alongside ignore_comment_authors rather than replacing or merging with it. They serve complementary but opposite purposes: ignore_comment_authors blocks feedback from specified users, while the bot opt-in explicitly allows certain bot-typed users. Keeping them separate preserves clarity and makes config intent explicit. (assumption)How I verified this
Tests (9 runs, last shown) —
cd /Users/eyalgolan/.<redacted>/worktrees/8fe972afa47745fb9da3387b878dd0c4.7034.0405e863 uv run pytest tests/test_pr_review_summaries.py tests/test_pr_watcher.py tests/test_config.py tests/test_structural_ [... 115 of 458 characters omitted from the middle ...] est_wake_pr_closed_repair.py tests/test_wake_tick_does_not_stall_scheduler.py tests/test_pr_watcher_cli_timeout.py -q -n 4 2>&1 | tail -15· full log9 commands recorded while working. Full verification log: ~/.no_human/artifacts/8fe972afa47745fb9da3387b878dd0c4/verification-attempt-5.md —
nh logs 8fe972af; the same log, every command with its captured output, is posted as this PR's How I verified this comment when posting succeeds. Whether it passed is in the Evidence table above: no entry here asserts a pass or a fail.UI evidence
Visual proof skipped: playwright not installed - run
nh doctor --fix-walksto enableOpened by no_human (attempt 5,
no-human/8fe972af-2→main). It never merges: review and merge this yourself, or runnh approve 8fe972af.