Refactor registerResourceInGatewayConfig to remove nolint:gocyclo - #5453
Merged
Merged
Conversation
somaz94
added a commit
to somaz94/somaz94
that referenced
this pull request
Jun 16, 2026
somaz94
marked this pull request as ready for review
June 19, 2026 02:44
salonichf5
approved these changes
Jun 22, 2026
bjee19
approved these changes
Jun 22, 2026
bjee19
enabled auto-merge (squash)
June 22, 2026 22:49
bjee19
disabled auto-merge
June 22, 2026 22:50
bjee19
enabled auto-merge (squash)
June 22, 2026 22:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem:
registerResourceInGatewayConfigcarries a//nolint:gocyclodirective (#5253).Solution: extract a
getOrCreateNginxResourceshelper and collapse the eight repetitive ObjectMetaswitchcases (Deployment, HPA, PDB, DaemonSet, Service, ServiceAccount, Role, RoleBinding) into single assignments. Behavior-preserving — no functional change (24 insertions / 62 deletions).Validation:
related: #5253