fix: replace raw NUL bytes in project run statuses - #8529
sohan87654 wants to merge 1 commit into
Conversation
lefarcen
added
risk/medium
|
Thanks @sohan87654 — this is a focused fix for the raw NUL-byte parsing issue in project run statuses. We’ve queued it for review. |
lefarcen
added
the
needs-validation
|
🧪 This PR has changes that need a manual QA pass before merge — please hold off self-merging for now; we’ll loop QA in once it’s merge-ready (and design/product have signed off, where applicable). |
lefarcen
left a comment
lefarcen
left a comment
There was a problem hiding this comment.
The existing Why, Changes, and Testing sections make the intent clear. Could you add the Surface area checklist (including the affected user-facing surface) and a short Bug fix verification entry that explicitly records the reported browser-load failure before and after this change? That will make the release-facing impact and regression check easy to trace.
PerishCode
left a comment
PerishCode
left a comment
There was a problem hiding this comment.
@sohan87654 I verified the three changed literals now use the source-safe \u0000 escape while preserving the same runtime NUL delimiter for sorting, subscription IDs, and summary lookup. The live patch contains no raw NUL bytes, and the change is tightly scoped to the reported browser parsing issue. Nice focused fix—thank you for preserving the existing join/split behavior.
Visual regression reviewHead: 0 changed · 53 unchanged · 0 new without baseline · 0 failed Unchanged cases
Visual diff is advisory only and does not block merging. |
|
Heads-up: PR #8476 is also open for the same browser parsing failure. Both PRs modify |
This branch has not been deployed
3 participants
Fixes #8475
Why
The web app had raw NUL bytes (
0x00) inside string literals inuseProjectRunStatuses.ts, which could cause a syntax error in Chromium/V8.Changes
\u0000escape sequence.Testing
git diff --check.