Remove smart picker dialog from text - #9040
xhon-pelushi wants to merge 2 commits into
Conversation
Fixes nextcloud#7795 Signed-off-by: xhon-pelushi <xhon@pelushi.com>
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution. Could you add some screenshots to illustrate the effective change in the UI? That will make the design review easier.
The failing static analysis test is unrelated. You do not need to worry about that.
|
Thanks @max-nextcloud — happy to add screenshots. Summary of the UI change while I gather them: Before: choosing a smart-picker result could open an extra dialog layer on top of the editor. I'll follow up with before/after screenshots as soon as I can capture them from a running instance. |
Signed-off-by: xhon-pelushi <xhon@pelushi.com>
|
Thanks @max-nextcloud — before/after screenshots for the smart picker UX change: Before (blocking dialog via
After (inline
Static HTML repros rendered with headless Chromium; code change removes the dialog call and focuses the editor with |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Thanks a lot @xhon-pelushi, much appreciated 🙏
I have two comments that I'd like to get addressed before approving the PR.
| logger.error('Smart picker promise rejected', error) | ||
| }) | ||
| this.menuOpen = false | ||
| this.editor?.chain().focus().insertContent('/').run() |
There was a problem hiding this comment.
Unfortunately this won't work if the cursor is within text. Inserting a / there doesn't open the inline picker. I think we should add a editor command to allow opening the inline picker programmatically (i.e. not only by typing /) and use that one instead. This would also solve the problem of stray slash characters when using the button and then closing the picker.
There was a problem hiding this comment.
Please remove the commit that adds the screenshots as they should not live in the repository.
This branch has not been deployed
3 participants
Fixes #7795