fix: don't try to load keys for empty path for groupfolder versions - #64992
Open
icewind1991 wants to merge 1 commit into
Open
icewind1991 wants to merge 1 commit into
icewind1991 wants to merge 1 commit into
Conversation
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
Altahrim,
CarlSchwan,
leftybournes and
salmart-dev
and removed request for
a team
October 1, 2026 15:59
Member
Author
|
/backport to stable35 |
Member
Author
|
/backport to stable34 |
Member
Author
|
/backport to stable33 |
Member
Author
|
Also needs nextcloud/groupfolders#5130 to have working encryption+versioning+groupfolders |
susnux
approved these changes
Oct 1, 2026
joshtrichards
approved these changes
Oct 2, 2026
joshtrichards
left a comment
joshtrichards
left a comment
Member
There was a problem hiding this comment.
Pragmatic for the time being I suppose...
Needs coverage or we'll regret it... ;-)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Groupfolder versions don't follow the naming schema that the logic relies on to get the original file.
Not going to pretend that I understand why it's getting the path of the original file though, but this seems to work, and without it it's fully broken 🙈
Checklist
3. to review, feature component)stable32)AI (if applicable)