fix(windows): Do not install PDB debug files when not building in Debug mode - #10911
claucambra wants to merge 2 commits into
Conversation
…ug mode Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
|
/backport to stable-34.0 |
… running debug build Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
|
mgallien
left a comment
mgallien
left a comment
There was a problem hiding this comment.
I think if we do not want them in release installer packages, why not use Release build type ?
after all, we do generate PDB to discard them
doing this change would prevent building installer packages with PDB if needed
In our case, in our build infra, we do grab the PDB files and archive them (not sure to what end). So doing this change we will still build and be able to store these files for our purposes, but not install them for the user |
2 participants
Summary
We currently install the PDB debug files in the release client; seems like we should only do this for debug builds
Checklist
AI (if applicable)