Skip to content

fix(activity): Use long as id for activity - #17771

Open
CarlSchwan wants to merge 1 commit into
masterfrom
bugfix/activity-pagination
Open

CarlSchwan wants to merge 1 commit into
masterfrom
bugfix/activity-pagination

Conversation

@CarlSchwan

Copy link
Copy Markdown
Member

This is already incorrect when there is more than 4.000.000 activity entries in an instance and get even more incorrect once activities are ported to snowflake ids.

Need nextcloud/android-library#2166 first

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

This is already incorrect when there is more than 4.000.000 activity entries in an instance and get even more incorrect
once activities are ported to snowflake ids.

Assisted-by: ClaudeCode:claude-sonnet-5-5
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3030
Correctness5555
Dodgy code178178
Experimental11
Malicious code vulnerability22
Multithreaded correctness2626
Performance3535
Security1616
Total343343

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown

📱 QA build

Download app-qa-debug.apk
QR code Open the QR code for this download
Commit ed5954b
Version 17771
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.

@codecov

codecov Bot commented Oct 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...vities/data/activities/ActivitiesServiceApiImpl.kt 0.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant