Remove Equinix Metal support - #1830
Merged
Merged
Conversation
Equinix Metal has shut down, so drop the provider-specific bootloader and menu logic that was built for it. - Delete the netboot.xyz-metal embedded iPXE script, which was hardcoded to metal.equinix.com and set ipxe_cloud_config to metal - Remove the metal/metal_x86_64/metal_arm64 cloud config blocks from boot.cfg, along with the metal and legacy packet dispatch lines; gce is now the only remaining cloud provider - Collapse the split metal/non-metal copy paths in the legacy and linux disk generation tasks back to a single path - Drop the equinixMetal platform from the Talos platform list - Trim bootloader_disks down to netboot.xyz and remove the now unused bootloader_multiple variable The netboot.xyz-metal.* artifacts will no longer be published. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HfC8w6Cf8AY7xLF3JoscYM
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (6 files)
Review Notes
Reviewed by claude-sonnet-4.5 · Input: 44 · Output: 3.7K · Cached: 199.4K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Equinix Metal has shut down, so this drops the provider-specific bootloader and menu logic that was built for it.
Changes
roles/netbootxyz/templates/disks/netboot.xyz-metal.j2— the embedded iPXE script for thenetboot.xyz-metalbootloader, hardcoded tometal.equinix.comand settingipxe_cloud_config metal.boot.cfg.j2— remove the:metal/:metal_x86_64/:metal_arm64cloud config blocks and themetal+ legacypacketdispatch lines.:gceis now the only remaining cloud provider.generate_disks_legacy.yml/generate_disks_linux.yml— these had split copy paths, one for metal (kpxe only) and one for everything else. Collapsed back to a single path and restored the unconditional-undionly.kpxecopy.defaults/main.yml— drop theequinixMetalplatform from the Talos platform list. The generic Talosmetal(bare metal) platform is unchanged.script/netbootxyz-overrides.yml—bootloader_disksis now justnetboot.xyz. Also removesbootloader_multiple, which existed only to signal the two-bootloader metal build and is not read anywhere in the role.Notes
CHANGELOG.mdstill mentions Equinix Metal in five historical entries. Those are a record of past releases, so they are left as-is.bootloader_filename == "netboot.xyz"guards ingenerate_disks.ymlare left in place — they read as generic "primary bootloader only" guards, and removing them would change behavior for anyone building an extra bootloader viabootloader_disks.netboot.xyz-metal.*artifacts (.kpxe,-snp.efi,-arm64-snp.efi). Any client still chainloading those URLs will 404, andboot.cfgno longer redirects them.🤖 Generated with Claude Code
https://claude.ai/code/session_01HfC8w6Cf8AY7xLF3JoscYM