Skip to content

revert the removal of SVG overflow:hidden, still needed for IE - #806

Open
bbenjamin wants to merge 1 commit into
necolas:masterfrom
bbenjamin:revert-ie-svg
Open

bbenjamin wants to merge 1 commit into
necolas:masterfrom
bbenjamin:revert-ie-svg

Conversation

@bbenjamin

Copy link
Copy Markdown

The overflow: hidden rule for SVG images was removed in this commit
004d58b
The comment for this commit states:

Drop support for older browsers: IE 9-, Android 4, Safari 7-.

This rule is still necessary for supported versions of IE (10/11), so it shouldn't have been removed. This PR brings it back.

@jakob-e

jakob-e commented Aug 18, 2020

Copy link
Copy Markdown

Please note that sometimes overflow visible is desirable
https://twitter.com/JoshWComeau/status/1288606220304158721

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants