Conversation
Union schema generation unwrapped Metadata before storing Struct members, so extra schema from msgspec.Meta on an annotated Struct was dropped. Keep the original union member when emitting schemas.
00200200
had a problem deploying
to
docs-preview
September 29, 2026 10:53 — with
GitHub Actions
Failure
00200200
had a problem deploying
to
docs-preview
October 2, 2026 18:28 — with
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
msgspec.json.schemaalready keeps extra JSON Schema frommsgspec.Metaon non-struct union members (for exampleAnnotated[None, Meta(description=...)]). The same metadata is dropped when it is attached to aStruct.The union walker unwraps
Metadatato classify each member, then previously stored only the innerStructType. Schema generation therefore never saw the annotation. This stores the original union member alongside the unwrapped type and uses that member when emittinganyOf.Reproduced on current
main:The same loss happens for tagged struct unions.
Tests
tests/unit/test_schema.py::test_optional_union_struct_member_metadata_preservedtests/unit/test_schema.py::test_struct_tagged_union_member_metadata_preservedpytest tests/unit/test_schema.py: 126 passed, 8 skipped.