fallback: pass object_pairs_hook a list of pairs - #744
Merged
Merged
Conversation
The pure-Python Unpacker passed a generator, so a hook that read the pairs twice saw nothing the second time, indexing raised TypeError, and a hook that ignored its argument left the map body unread. The C extension and the docstring give a list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pure-Python
Unpackerpassesobject_pairs_hooka generator, while the C extension and the docstring give it a list of pairs. On PyPy or withMSGPACK_PUREPYTHON=1:{};pairs[0]andlen(pairs)raiseTypeError;ExtraDatafromunpackb).This builds the list eagerly, keeping the
strict_map_keycheck on each key; it is Finding 5 of #683. The check now runs whether or not the hook iterates, which matches the fallback's dict path and a hook likelist.pytest testandMSGPACK_PUREPYTHON=1 pytest testpass; the new test fails on main under the fallback only.Written with AI assistance (Claude); I have reviewed the change.