Skip to content

fix: check return code in unpack_callback_int64 #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 4 commits into from
Apr 21, 2026
Merged

fix: check return code in unpack_callback_int64 #665

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5142b3d
fix: check return code in unpack_callback_int64
KowalskiThomas Apr 18, 2026
a85e02d
refactor: remove LONG_MAX check
KowalskiThomas Apr 20, 2026
1e28db7
Apply suggestion from @methane
methane Apr 21, 2026
77f5a53
Simplify PyObject creation in unpack_callback_int64
methane Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: remove LONG_MAX check
  • Loading branch information
@KowalskiThomas
KowalskiThomas committed Apr 20, 2026
commit a85e02d6a69d51a070fb854ae399ae41f2480ae4
7 changes: 1 addition & 6 deletions msgpack/unpack.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,7 @@ static inline int unpack_callback_uint32(unpack_user* u, uint32_t d, msgpack_unp

static inline int unpack_callback_uint64(unpack_user* u, uint64_t d, msgpack_unpack_object* o)
{
PyObject *p;
if (d > LONG_MAX) {
p = PyLong_FromUnsignedLongLong((unsigned PY_LONG_LONG)d);
} else {
p = PyLong_FromLong((long)d);
}
PyObject *p = PyLong_FromUnsignedLongLong((unsigned PY_LONG_LONG)d);

@ThomasWaldmann ThomasWaldmann Apr 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, but it seems correct.

(I am not really familiar with the C api.)

if (!p)
return -1;
*o = p;
Expand Down
Loading