Skip to content

asShort in ImmutableLongValueImpl should check isInShortRange #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
komamitsu merged 3 commits into from
Nov 11, 2015
Merged

asShort in ImmutableLongValueImpl should check isInShortRange #287

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
382845b
Fixed: asShort in LongValueImpl should check isInShortRange instead o…
mecp Nov 4, 2015
919ab70
added tests for integer value range checks and casts
mecp Nov 10, 2015
6b9d5d3
fixed integer literal related issue in integer range check test
mecp Nov 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fixed: asShort in LongValueImpl should check isInShortRange instead o… 
…f isInByteRange
  • Loading branch information
@mecp
mecp committed Nov 4, 2015
commit 382845bc6e433761be83f42065ed098adc837799
2 changes: 1 addition & 1 deletion msgpack-core/src/main/java/org/msgpack/value/impl/ImmutableLongValueImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ public byte asByte()
@Override
public short asShort()
{
if (!isInByteRange()) {
if (!isInShortRange()) {
throw new MessageIntegerOverflowException(value);
}
return (short) value;
Expand Down