Conversation
inotify reports IN_OPEN for plain reads, and notify-debouncer-mini drops the event kind, so the app reading its own instance files (hashing mods during a content sync, parsing options.txt for the locale index) looked like a change and queued another pass over the same files. Filter open events out before they reach the debouncer.
Contributor
Pull request changelogAppAddedChangedDeprecatedRemovedFixedSecurityWebsiteAddedChangedDeprecatedRemovedFixedSecurityHostingAddedChangedDeprecatedRemovedFixedSecurity |
Contributor
Author
|
Measured on 0.21.6 (Flatpak, Linux Mint), two machines, app open, no game running, 3 min after launch. #7561 is in 0.21.6 and The launcher is still writing, all of it to A per-table content hash taken 60 s apart shows only
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7624
On Linux, notify's inotify backend watches
IN_OPEN, andnotify-debouncer-minidrops the event kind, so the watcher can't tell a read from a write. The app's own reads then look like changes: hashing jars during a content sync queues another content sync, and readingoptions.txtfor the locale index queues another index pass. This wraps the watcher and dropsAccess(Open)events before they reach the debouncer. Modify, create, delete and close-write still come through.Same notify 8.2.0 / debouncer-mini 0.7.0, a
mods/dir watched recursively, five reads of a jar, then one modify, one create and one delete: