Skip to content

Refactor checkGlobals() error message creation #3711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plroebuck merged 12 commits into from
Feb 11, 2019
Merged

Refactor checkGlobals() error message creation #3711

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d613cd5
feat(lib/utils.js): Add utility routines
plroebuck Feb 4, 2019
0816417
refactor(lib/runner.js): Refactor error creation of detected leaks
plroebuck Feb 4, 2019
ff04d19
test(unit/runner.spec.js): Update spec for leak detection change
plroebuck Feb 4, 2019
d7b4266
Merge branch 'master' into plroebuck/checkGlobals-refactor
plroebuck Feb 4, 2019
6585829
Merge branch 'master' into plroebuck/checkGlobals-refactor
plroebuck Feb 5, 2019
17845e7
test(unit/runner.spec.js): Fix after rebase
plroebuck Feb 5, 2019
470e562
test(unit/runner.spec.js): Fix to emit using constant names
plroebuck Feb 7, 2019
5bb337d
test(integration/reporters.spec.js): Replace inline with call to util…
plroebuck Feb 7, 2019
36dbfbf
test(unit/utils.spec.js): Add tests for new methods
plroebuck Feb 7, 2019
7ec4f1b
refactor(lib/mocha.js): Use sQuote rather than hardcoded inline
plroebuck Feb 8, 2019
dceaf8e
test(integration/reporters.spec.js): Tweak access to dQuote
plroebuck Feb 8, 2019
c7c7214
refactor(lib/utils.js): Use quotation methods
plroebuck Feb 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(unit/runner.spec.js): Fix to emit using constant names
  • Loading branch information
@plroebuck
plroebuck committed Feb 7, 2019
commit 470e562535c293e8c35493b053f2e85b13f5338b
4 changes: 2 additions & 2 deletions test/unit/runner.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,7 +563,7 @@ describe('Runner', function() {
// Fake stack-trace
err.stack = [message].concat(stack).join('\n');

runner.on('fail', function(_hook, _err) {
runner.on(EVENT_TEST_FAIL, function(_hook, _err) {
var filteredErrStack = _err.stack.split('\n').slice(1);
expect(
filteredErrStack.join('\n'),
Expand All @@ -583,7 +583,7 @@ describe('Runner', function() {
// Fake stack-trace
err.stack = [message].concat(stack).join('\n');

runner.on('fail', function(_hook, _err) {
runner.on(EVENT_TEST_FAIL, function(_hook, _err) {
var filteredErrStack = _err.stack.split('\n').slice(-3);
expect(
filteredErrStack.join('\n'),
Expand Down