Skip to content

golangci-lint: enable usetesting linter - #53720

Merged
thaJeztah merged 30 commits into
moby:masterfrom
thaJeztah:lint_usetesting
Sep 28, 2026
Merged

thaJeztah merged 30 commits into
moby:masterfrom
thaJeztah:lint_usetesting

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

relates to:

Release notes (optional)

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah

Copy link
Copy Markdown
Member Author

I think the flaky tests check on Windows is just genuinely taking too long; this PR touches various tests, and it's probably running them all in a loop, which .. may take some time on Windows? The "embedded" check is faster, so makes it just within 2 hours, but external containerd is slower, so exceeds the timeout, and gets cancelled;

Screenshot 2026-09-21 at 12 09 50 Screenshot 2026-09-21 at 12 10 09 Screenshot 2026-09-21 at 12 10 25

@thaJeztah
thaJeztah marked this pull request as ready for review September 21, 2026 16:06
@thaJeztah
thaJeztah requested a review from vvoland September 25, 2026 14:40
@vvoland

vvoland commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Ah yes, that's an unfortunate consequence of running this workflow over a PR that changes so many tests 🙈

@thaJeztah
thaJeztah merged commit 5d8f006 into moby:master Sep 28, 2026
348 of 387 checks passed
@thaJeztah
thaJeztah deleted the lint_usetesting branch September 28, 2026 08:15
renovate Bot added a commit to kimdre/doco-cd that referenced this pull request Oct 12, 2026
This PR contains the following updates:

| Package | Change |
[Age](https://docs.renovatebot.com/merge-confidence/) |
[Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [github.com/moby/moby/client](https://redirect.github.com/moby/moby) |
`v0.6.0` → `v0.6.2` |
![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fmoby%2fmoby%2fclient/v0.6.2?slim=true)
|
![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fmoby%2fmoby%2fclient/v0.6.0/v0.6.2?slim=true)
|

---

### Release Notes

<details>
<summary>moby/moby (github.com/moby/moby/client)</summary>

###
[`v0.6.2`](https://redirect.github.com/moby/moby/releases/tag/client/v0.6.2)

[Compare
Source](https://redirect.github.com/moby/moby/compare/v0.6.1...v0.6.2)

#### 0.6.2

##### Changelog

- client: bump github.com/docker/go-connections v0.8.2,
github.com/Azure/go-ansiterm
[`8c912ac`](https://redirect.github.com/moby/moby/commit/8c912ac31dd4).
[moby/moby#53891](https://redirect.github.com/moby/moby/pull/53891)
- Fix request cancellation and deadlines during client HTTP upgrade
handshakes.
[moby/moby#53889](https://redirect.github.com/moby/moby/pull/53889)

###
[`v0.6.1`](https://redirect.github.com/moby/moby/releases/tag/client/v0.6.1)

[Compare
Source](https://redirect.github.com/moby/moby/compare/v0.6.0...v0.6.1)

#### 0.6.1

##### Changelog

- client: add `WithHTTPRequestHook` option.
[moby/moby#53671](https://redirect.github.com/moby/moby/pull/53671)
- client: deprecate `WithResponseHook` in favor of
`WithHTTPResponseHook`.
[moby/moby#53666](https://redirect.github.com/moby/moby/pull/53666)
- client: fix `WithHTTPResponseHook` hooks not being called for hijacked
HTTP connections.
[moby/moby#53821](https://redirect.github.com/moby/moby/pull/53821)
- client: postRaw: use consistent order or arguments.
[moby/moby#53677](https://redirect.github.com/moby/moby/pull/53677)
- client: prevent response hooks from consuming response body.
[moby/moby#53667](https://redirect.github.com/moby/moby/pull/53667)
- client: remove redundant cloning of response hooks.
[moby/moby#53822](https://redirect.github.com/moby/moby/pull/53822)
- client: update github.com/docker/go-connections v0.8.1.
[moby/moby#53708](https://redirect.github.com/moby/moby/pull/53708)
- golangci-lint: enable usetesting linter.
[moby/moby#53720](https://redirect.github.com/moby/moby/pull/53720)
- vendor: github.com/moby/moby/api v1.56.1.
[moby/moby#53837](https://redirect.github.com/moby/moby/pull/53837)

</details>

---

### Configuration

📅 **Schedule**: (in timezone Europe/Berlin)

- Branch creation
- At 10:00 PM through 11:59 PM and 12:00 AM through 07:59 AM (`*
22-23,0-7 * * *`)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/kimdre/doco-cd).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0NC4xMzQuMSIsInVwZGF0ZWRJblZlciI6IjQ0LjEzNC4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants