Skip to content

Bug in test_algebra.py: unexpected keyword argument 'extra_arg'  #26

Description

@szsdk

The error raising from

np.exp(q, extra_arg=True)

is unexpected keyword argument instead of the NotImplementedError to be caught.

Activity

  1. moble commented on Jul 28, 2021

    @moble
    Owner

    I can't reproduce this on my own computer, or on the CI run in this repo. Can you provide more details about your python version, and the full output?

  2. szsdk commented on Jul 30, 2021

    @szsdk
    Author

    My numpy version is 1.21.0.

    According the doc, the exp does not accept extra_arg argument.

  3. moble commented on Oct 21, 2021

    @moble
    Owner

    My numpy version is 1.21.0.

    Ah, okay. That version is actually not yet supported by numba, which is critical to this package. It is actually possible to override the dependencies to get it to install anyway, but I don't test for that situation, and don't support it. Nonetheless, I can update the test to prepare for when numba actually supports versions >=1.21 (which should be soon). The changes in numpy are described here

    According the doc, the exp does not accept extra_arg argument.

    That's right; this test is making sure that such an extra argument is not silently ignored.

  4. added a commit that references this issue on Oct 21, 2021
    10728de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions