enhance: bump simdjson from v3.12.2 to v5.0.2 - #53941
Merged
Merged
Conversation
mergify
Bot
added
dco-passed
Contributor
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Contributor
❌ CI Loop Results
|
| Stage | Result | Duration | Tests |
|---|---|---|---|
| ✅ Build | SUCCESS | 13.8min | - |
| ✅ Code-Check | SUCCESS | 5.6min | - |
| ❌ UT-Integration | FAILURE | 39.4min | - |
| ✅ UT-GO | SUCCESS | 28.6min | - |
| ✅ UT-CPP-Cov | SUCCESS | 61.7min | 9706 total, 9706 passed, 0 failed |
Total: 98min | Pipeline | Artifacts
Overall Coverage: 77.0%
Failed Test Logs:
- UT-Integration: view log
Signed-off-by: Alexandr Guzhva <alexanderguzhva@gmail.com>
alexanderguzhva
force-pushed
the
upgrade_simdjson_5
branch
from
October 4, 2026 21:22
311cedf to
adfcd9d
Compare
alexanderguzhva
changed the title
Contributor
Collaborator
|
/ci-rerun-e2e-default |
This was referenced Oct 5, 2026
xiaofan-luan
added a commit
that referenced
this pull request
Oct 5, 2026
#53964) issue: #53962 The Struct Array partial-update lifecycle test can request manual compaction while its freshly flushed segments are still being sorted. DataCoord then returns the valid no-plan result `-1`, and the immediate positive-ID assertion fails before the compaction/reload checks run. Wait for vector-index readiness, then retry only `-1` against a monotonic 120-second deadline, passing the remaining budget to each compact RPC. Require an accepted compaction to complete and check the baseline both immediately afterward and after release/load. RPC failures, unexpected IDs, timeouts, and data mismatches remain failures. This follows the existing Struct nullable lifecycle test's approach from #52108. The observed failure is in [PR #53941's E2E run](https://jenkins-milvus-ci.milvus.io/job/MILVUS-CI-V2-PR-PIPELINES/job/milvus-e2e-pipeline-gcp/61102/console); this change does not modify server compaction behavior. Validation: - Ruff lint and format checks, Python syntax compilation, and `git diff --check`. - Executed the changed statements extracted from the actual file with simulated time/RPC responses: retry then success, persistent no-plan timeout, invalid IDs, RPC failure, index/compaction wait failures, and both post-compaction and post-reload data mismatches. - Live E2E has not been run against this fix locally; CI validation is pending. The separately requested rerun of #53941 uses its original head and does not validate this patch. Signed-off-by: xiaofanluan <xf@hjjaq.com> Co-authored-by: xiaofanluan <xf@hjjaq.com>
Collaborator
|
/lgtm |
Collaborator
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
[approval-status] effective-owner-approvals=1 [xiaofan-luan(comment)]; do-not-merge/disable-approve-self=not-required; do-not-merge/doc-need-two-approve=disabled; ignored=[none] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #53940
The new version is slightly (up to several percents) faster on benchmarks.
Tested on an ARM machine