Repository navigation
✨ handle debugee connection timeout - #812
Merged
Don Jayamanne (DonJayamanne) merged 4 commits intoFeb 17, 2018
Merged
Don Jayamanne (DonJayamanne) merged 4 commits into
Don Jayamanne (DonJayamanne) merged 4 commits into
Conversation
Don Jayamanne (DonJayamanne)
requested a review
from Mikhail Arkhipov (MikhailArkhipov)
February 16, 2018 22:54
| return launcher.LaunchApplicationToDebug(serverInfo); | ||
| } | ||
| private async waitForDebuggerConnection() { | ||
| return new Promise<void>(async (resolve, reject) => { |
There was a problem hiding this comment.
I'd make this configurable
| reject(new Error('Timeout waiting for debugger connection')); | ||
| }, DEBUGGER_CONNECT_TIMEOUT); | ||
|
|
||
| await this.debugServer!.client; |
There was a problem hiding this comment.
If this throws, do we need to unref still? Maybe finally ?
Mikhail Arkhipov (MikhailArkhipov)
approved these changes
Feb 16, 2018
Codecov Report
@@ Coverage Diff @@
## master #812 +/- ##
==========================================
- Coverage 63.43% 63.32% -0.12%
==========================================
Files 258 258
Lines 11770 11789 +19
Branches 2082 2084 +2
==========================================
- Hits 7466 7465 -1
- Misses 4296 4316 +20
Partials 8 8
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #764