Skip to content

close restart session right away #7153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ian Huff (IanMatthewHuff) merged 2 commits into from
Aug 30, 2019
Merged

close restart session right away #7153

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a6202a
close restart session right away
IanMatthewHuff Aug 29, 2019
277d904
ignore errors on await, don't want to stop and wait for shutdown
IanMatthewHuff Aug 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
ignore errors on await, don't want to stop and wait for shutdown
  • Loading branch information
@IanMatthewHuff
IanMatthewHuff committed Aug 29, 2019
commit 277d90430ed07490a7282b08c23bdf6688d3092b
4 changes: 2 additions & 2 deletions src/client/datascience/jupyter/jupyterSession.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export class JupyterSession implements IJupyterSession {
oldSession.statusChanged.disconnect(oldStatusHandler);
}

this.shutdownSession(oldSession, undefined);
this.shutdownSession(oldSession, undefined).ignoreErrors();
} else {
throw new Error(localize.DataScience.sessionDisposed());
}
Expand Down Expand Up @@ -206,7 +206,7 @@ export class JupyterSession implements IJupyterSession {
traceInfo(`Error waiting for restart session: ${exc}`);
tryCount += 1;
if (result) {
this.shutdownSession(result, undefined);
this.shutdownSession(result, undefined).ignoreErrors();
}
result = undefined;
exception = exc;
Expand Down