Skip to content

Fix messed up svgs from accessibility fixes - #6216

Merged
Rich Chiodo (rchiodo) merged 1 commit into
masterfrom
rchiodo/fix_plot_svgs
Jun 18, 2019
Merged

Fix messed up svgs from accessibility fixes#6216
Rich Chiodo (rchiodo) merged 1 commit into
masterfrom
rchiodo/fix_plot_svgs

Conversation

@rchiodo

@rchiodo Rich Chiodo (rchiodo) commented Jun 17, 2019

Copy link
Copy Markdown

Svgs got messed up when I removed the 'id' tags.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@rchiodo Rich Chiodo (rchiodo) added the no-changelog No news entry required label Jun 17, 2019
@rchiodo
Rich Chiodo (rchiodo) merged commit cbb4c8d into master Jun 18, 2019
@rchiodo
Rich Chiodo (rchiodo) deleted the rchiodo/fix_plot_svgs branch June 18, 2019 00:11
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rchiodo