Skip to content

March 2019 point release with debugger fixes #5056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Don Jayamanne (DonJayamanne) merged 9 commits into from
Apr 2, 2019
Merged

March 2019 point release with debugger fixes #5056

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
770c8ed
New point release
DonJayamanne Apr 1, 2019
86cd5fa
Display survey banner for LS when using current LS
DonJayamanne Apr 2, 2019
14b153d
Update version of PTVSD
DonJayamanne Apr 2, 2019
dc50309
Telemetry
DonJayamanne Apr 2, 2019
8bbdb95
Oops
DonJayamanne Apr 2, 2019
ad1f3e9
Linter issues
DonJayamanne Apr 2, 2019
5f5aea3
Update CHANGELOG.md
brettcannon Apr 2, 2019
509b565
Update CHANGELOG.md
brettcannon Apr 2, 2019
3ca11bd
Update CHANGELOG.md
brettcannon Apr 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Telemetry
  • Loading branch information
@DonJayamanne
DonJayamanne committed Apr 2, 2019
commit dc5030927cb73a31c6db362e8ebe9b4ae131d88c
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@
* Fix issue with expanding variables in watch window and hover.
* Fix issue with launching a sub-module.

### Code Health

1. Capture telemetry to track installer used when installing packages.
Comment thread
DonJayamanne marked this conversation as resolved.
Outdated
([#5063](https://github.com/Microsoft/vscode-python/issues/5063))


## 2019.3.1 (28 March 2019)

### Enhancements
Expand Down
4 changes: 4 additions & 0 deletions src/client/common/installer/moduleInstaller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,15 @@ import { STANDARD_OUTPUT_CHANNEL } from '../constants';
import { ITerminalServiceFactory } from '../terminal/types';
import { ExecutionInfo, IConfigurationService, IOutputChannel } from '../types';
import { noop } from '../utils/misc';
import { sendTelemetryEvent } from '../../telemetry';
import { EventName } from '../../telemetry/constants';

@injectable()
export abstract class ModuleInstaller {
public abstract get displayName(): string
constructor(protected serviceContainer: IServiceContainer) { }
public async installModule(name: string, resource?: vscode.Uri): Promise<void> {
sendTelemetryEvent(EventName.PYTHON_INSTALL_PACKAGE, undefined, { installer: this.displayName });
const executionInfo = await this.getExecutionInfo(name, resource);
const terminalService = this.serviceContainer.get<ITerminalServiceFactory>(ITerminalServiceFactory).getTerminalService(resource);

Expand Down
1 change: 1 addition & 0 deletions src/client/telemetry/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ export enum EventName {
REFACTOR_EXTRACT_FUNCTION = 'REFACTOR_EXTRACT_FUNCTION',
REPL = 'REPL',
PYTHON_INTERPRETER = 'PYTHON_INTERPRETER',
PYTHON_INSTALL_PACKAGE = 'PYTHON_INSTALL_PACKAGE',
PYTHON_INTERPRETER_DISCOVERY = 'PYTHON_INTERPRETER_DISCOVERY',
PYTHON_INTERPRETER_AUTO_SELECTION = 'PYTHON_INTERPRETER_AUTO_SELECTION',
PYTHON_INTERPRETER_ACTIVATION_ENVIRONMENT_VARIABLES = 'PYTHON_INTERPRETER_ACTIVATION_ENVIRONMENT_VARIABLES',
Expand Down
2 changes: 1 addition & 1 deletion src/client/telemetry/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ export interface IEventNamePropertyMapping {
[EventName.HOVER_DEFINITION]: never | undefined;
[EventName.KNOWN_IMPORT_FROM_FILE]: { import: string };
[EventName.KNOWN_IMPORT_FROM_EXECUTION]: { import: string };
[EventName.LINTER_NOT_INSTALLED_PROMPT]: LinterInstallPromptTelemetry;
[EventName.PYTHON_INSTALL_PACKAGE]: { installer: string };
[EventName.LINTING]: LintingTelemetry;
[EventName.PLATFORM_INFO]: Platform;
[EventName.PYTHON_INTERPRETER]: PythonInterpreterTelemetry;
Expand Down