Skip to content

Strong typing of telemetry properties - #4031

Merged
Don Jayamanne (DonJayamanne) merged 3 commits into
microsoft:masterfrom
DonJayamanne:part2
Jan 17, 2019
Merged

Strong typing of telemetry properties#4031
Don Jayamanne (DonJayamanne) merged 3 commits into
microsoft:masterfrom
DonJayamanne:part2

Conversation

@DonJayamanne

@DonJayamanne Don Jayamanne (DonJayamanne) commented Jan 17, 2019

Copy link
Copy Markdown

For #2904

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • [n/a] Unit tests & system/integration tests are added/updated
  • [n/a] Test plan is updated as appropriate
  • [n/a] package-lock.json has been regenerated by running npm install (if dependencies have changed)

@codecov

codecov Bot commented Jan 17, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #4031 into master will increase coverage by 23%.
The diff coverage is 97%.

@@           Coverage Diff            @@
##           master   #4031     +/-   ##
========================================
+ Coverage      56%     78%    +23%     
========================================
  Files         333     410     +77     
  Lines       13979   19079   +5100     
  Branches     2151    3042    +891     
========================================
+ Hits         7726   14859   +7133     
+ Misses       5773    4217   -1556     
+ Partials      480       3    -477
Flag Coverage Δ
#Linux 53% <86%> (?)
#Windows 68% <86%> (?)

rchiodo
Rich Chiodo (rchiodo) reviewed Jan 17, 2019
View reviewed changes
Comment thread src/client/common/logger.ts
rchiodo
Rich Chiodo (rchiodo) requested changes Jan 17, 2019
View reviewed changes

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

rchiodo
Rich Chiodo (rchiodo) approved these changes Jan 17, 2019
View reviewed changes

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne Don Jayamanne (DonJayamanne) added the no-changelog No news entry required label Jan 17, 2019
IanMatthewHuff
Ian Huff (IanMatthewHuff) approved these changes Jan 17, 2019
View reviewed changes

@IanMatthewHuff Ian Huff (IanMatthewHuff) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit 3f78993 into microsoft:master Jan 17, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanMatthewHuff Ian Huff (IanMatthewHuff) IanMatthewHuff approved these changes
@rchiodo Rich Chiodo (rchiodo) rchiodo approved these changes

Assignees

No one assigned

Labels

no-changelog No news entry required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DonJayamanne @IanMatthewHuff @rchiodo