Repository navigation
command renames for clarity / consistency - #3943
Merged
Ian Huff (IanMatthewHuff) merged 1 commit intoJan 9, 2019
Merged
Ian Huff (IanMatthewHuff) merged 1 commit into
Ian Huff (IanMatthewHuff) merged 1 commit into
Conversation
Ian Huff (IanMatthewHuff)
requested review from
Rich Chiodo (rchiodo) and
Rong Lu (ronglums)
January 9, 2019 18:25
Member
Author
|
To note. I think that our usage of Notebook versus notebook is possibly incorrect as well, but it's a bit harder to suss out the actual correct usage here. Even the official docs seem to vary some. Basically always lowercase 'n' when notebook is by itself, but sometimes upper and sometimes lower case 'n' when it follows "Jupyter" |
Codecov Report
@@ Coverage Diff @@
## master #3943 +/- ##
======================================
+ Coverage 78% 78% +1%
======================================
Files 402 402
Lines 18572 18572
Branches 2985 2985
======================================
+ Hits 14334 14352 +18
+ Misses 4236 4218 -18
Partials 2 2
Continue to review full report at Codecov.
|
Rich Chiodo (rchiodo)
approved these changes
Jan 9, 2019
Ian Huff (IanMatthewHuff)
deleted the
dev/ianhu/fixLaunchJupyterCommandName
branch
January 9, 2019 20:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #3925
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)