Repository navigation
Mock jupyter apis such that they can be faked to have tests run more reliably - #3853
Merged
Merged
Conversation
Rich Chiodo (rchiodo)
requested review from
Don Jayamanne (DonJayamanne),
Ian Huff (IanMatthewHuff) and
Derek Keeler (d3r3kk)
January 3, 2019 17:17
| // Do the same thing as dispose so that we regenerate | ||
| // all of our commands | ||
| return Promise.resolve(this.dispose()); | ||
| this.dispose(); |
Author
There was a problem hiding this comment.
this [](start = 8, length = 4)
I think this might be incorrect. It should wait for the dispose. #Resolved
Author
There was a problem hiding this comment.
Oh actually the dispose() in this class doesn't return a promise, so this is correct.
In reply to: 245071855 [](ancestors = 245071855)
Don Jayamanne (DonJayamanne)
approved these changes
Jan 3, 2019
| } | ||
|
|
||
| async function verifySimple(jupyterServer: INotebookServer | undefined, code: string, expectedValue: any): Promise<void> { | ||
| async function verifySimple(jupyterServer: INotebookServer | undefined, code: string, expectedValue: any) : Promise<void> { |
Member
There was a problem hiding this comment.
[](start = 109, length = 1)
Not that I care too much, but this formatting seems funny. Did the linter add this? #WontFix
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #3556
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)