Skip to content

Preparation for 2018.12.1 point release #3708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Derek Keeler (d3r3kk) merged 3 commits into from
Dec 14, 2018
Merged

Preparation for 2018.12.1 point release #3708

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e67d505
Preparation for 2018.12.1 point release
d3r3kk Dec 14, 2018
9971509
Add info for failing PlatformService test on Windows CI agent
d3r3kk Dec 14, 2018
7e2219f
Remove use of node.os package in favour of the 'arch' package to test…
d3r3kk Dec 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add info for failing PlatformService test on Windows CI agent
  • Loading branch information
@d3r3kk
d3r3kk committed Dec 14, 2018
commit 99715094a4ed71b3cff36214d6a18572ef4339e0
2 changes: 1 addition & 1 deletion src/test/common/platform/platformService.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ suite('PlatformService', () => {
const svc = new PlatformService();
const result = svc.is64bit;

expect(result).to.be.equal(expected, 'invalid value');
expect(result).to.be.equal(expected, `Invalid value for arch(). os.arch() reports '${os.arch()}' (looking for 'x64').`);
});

test('getVersion on Mac/Windows', async function () {
Expand Down