Skip to content

fix: dispose orphaned progress notifications on language server shutdown - #26130

Open
MOHAMMED WASIM KHAN (wasim-builds) wants to merge 1 commit into
microsoft:mainfrom
wasim-builds:fix/issue-16750-dispose-progress
Open

fix: dispose orphaned progress notifications on language server shutdown#26130
MOHAMMED WASIM KHAN (wasim-builds) wants to merge 1 commit into
microsoft:mainfrom
wasim-builds:fix/issue-16750-dispose-progress

Conversation

@wasim-builds

@wasim-builds MOHAMMED WASIM KHAN (wasim-builds) commented Aug 30, 2026

Copy link
Copy Markdown

Fixes #16750

When a language server crashed or was restarted, any active progress notifications (started via python/beginProgress) would remain orphaned in the UI because the progressDeferred promise was never resolved during dispose().

This PR ensures that if the ProgressReporting instance is disposed, any pending progress deferred is resolved, closing the orphaned UI notification.

Wasim
fix(lsp): dispose orphaned progress notifications on client shutdown
1165ac6 
Fixes microsoft#16750

Ensures that any pending progress UI notifications are resolved when the Language Server progress tracking is disposed, preventing orphaned progress bars from hanging indefinitely in the status bar if the server restarts or crashes.
Copilot AI lite review requested due to automatic review settings August 30, 2026 11:11
Copilot AI reviewed Aug 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@bschnurr

Bill Schnurr (bschnurr) commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

🔒 Automated review in progress — Bill Schnurr (@bschnurr) is auto-reviewing this PR.

@bschnurr

Bill Schnurr (bschnurr) commented Aug 31, 2026

Copy link
Copy Markdown
Member

Verification: The relevant tests could not be fully run in the isolated environment; this review is not fully verified.

Result: could-not-verify

Summary: Verification could not run because no trusted sandbox image is configured for `microsoft/vscode-python`. The PR adds no tests, and existing tests do not reference `ProgressReporting` or its progress notifications. The new disposal behavior therefore remains unverified and uncovered.

Test runs: 1 not run

  • ⚠️ Not run | Verification preflight and PR diff discovery | printf 'AUTOMATION_SANDBOX_PROFILE=%s\n' "${AUTOMATION_SANDBOX_PROFILE:-}"; git status --short; git diff --name-status upstream/main...HEAD; git diff --stat upstream/main...HEAD; if [ -d node_modules ]; then printf 'node_modules=present\n'; else printf 'node_modules=missing\n'; fi; if [ -d out ]; then printf 'out=present\n'; else printf 'out=missing\n'; fi; git diff --unified=20 upstream/main...HEAD
⚠️ Verification preflight and PR diff discovery diagnostic output 
Container verification could not start: no trusted sandbox image is configured for microsoft/vscode-python, and local execution was not authorized.

bschnurr
Bill Schnurr (bschnurr) approved these changes Aug 31, 2026
View reviewed changes

@bschnurr Bill Schnurr (bschnurr) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@bschnurr Bill Schnurr (bschnurr) added the review-auto:approved Automated review: no blocking findings (approval posted). label Aug 31, 2026
@wasim-builds

MOHAMMED WASIM KHAN (wasim-builds) commented Oct 1, 2026

Copy link
Copy Markdown
Author

Hello everyone,

Checking in regarding this contribution for microsoft/vscode-python (fix: dispose orphaned progress notifications on language server shutdown). Contributing around VS Code Python language tooling and language server lifecycle management has been exciting, and I'd love to help out with additional improvements and features across microsoft/vscode-python.

I am available for freelance/contract projects, full-time opportunities, or joining the team as a regular contributor.

You're welcome to connect or view my profile and repositories at https://github.com/wasim-builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@bschnurr Bill Schnurr (bschnurr) bschnurr approved these changes

Assignees

No one assigned

Labels

review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dispose orphaned progress notifications behind when using progress reporting in language servers

3 participants

@wasim-builds @bschnurr