Skip to content

Fix #26039: REPL prompt disappears when builtins/globals shadowed under PYTHONSTARTUP #26045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Eduardo Villalpando Mello (edvilme) merged 4 commits into from
Sep 16, 2026
Merged

Fix #26039: REPL prompt disappears when builtins/globals shadowed under PYTHONSTARTUP #26045

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f3b5e40
Fix #26045: capture PS1 dependencies as closures to survive shadowed …
mohityadav8 Sep 14, 2026
d562064
Fix #26045: capture PS1 builtins as _initialize locals to survive sha…
mohityadav8 Sep 14, 2026
68e5cbf
Update python_files/tests/test_shell_integration.py
mohityadav8 Sep 14, 2026
de18454
Fix #26045: use exact assertion per tests-no-partial-asserts policy; …
mohityadav8 Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update python_files/tests/test_shell_integration.py 
Co-authored-by: Eduardo Villalpando Mello <eduardo.villalpando.mello@gmail.com>
  • Loading branch information
@mohityadav8 @edvilme
mohityadav8 and edvilme authored Sep 14, 2026
commit 68e5cbf4159758c9278a3aa8bd39dfec4e204efc
2 changes: 1 addition & 1 deletion python_files/tests/test_shell_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def test_prompt_survives_shadowed_builtins_under_pythonstartup():
return

source = PYTHONRC_PATH.read_text(encoding="utf-8")
namespace = {"__name__": "__main__"}
namespace: dict[str, Any] = {"__name__": "__main__"}
exec(compile(source, str(PYTHONRC_PATH), "exec"), namespace)

namespace.update(
Expand Down