Skip to content

Use sendText to send Python code to Terminal REPL for Python >= 3.13 #24765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anthony Kim (anthonykim1) merged 15 commits into from
Feb 4, 2025
Merged

Use sendText to send Python code to Terminal REPL for Python >= 3.13 #24765

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
1187591
use sendText for >=3.13
anthonykim1 Jan 30, 2025
fdca3c1
use sendText when sending to >= 3.13
anthonykim1 Jan 30, 2025
78f9298
make my code cleaner
anthonykim1 Jan 31, 2025
c6dfed7
why
anthonykim1 Feb 2, 2025
3b338ee
why
anthonykim1 Feb 2, 2025
399847e
why
anthonykim1 Feb 2, 2025
33ec0ab
see if different
anthonykim1 Feb 2, 2025
f1e8d44
why no async
anthonykim1 Feb 2, 2025
ec4a048
remove unused
anthonykim1 Feb 2, 2025
f2fbb9f
a
anthonykim1 Feb 2, 2025
70629bf
see if its because of 3.13
anthonykim1 Feb 2, 2025
eb3122d
resolve merge conflict
anthonykim1 Feb 3, 2025
7b4fb2a
uncomment my code
anthonykim1 Feb 3, 2025
53c80fa
reset interpreterService for tests
anthonykim1 Feb 3, 2025
7e5a10c
bring my code back
anthonykim1 Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reset interpreterService for tests
  • Loading branch information
@anthonykim1
anthonykim1 committed Feb 3, 2025
commit 53c80fa14b73987ae70d3086dd8072f212813097
3 changes: 1 addition & 2 deletions src/test/common/terminals/service.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,7 @@ suite('Terminal Service', () => {
}
disposables.filter((item) => !!item).forEach((item) => item.dispose());
sinon.restore();
// reset setup for interpreterService
// interpreterService.reset();
interpreterService.reset();
});

test('Ensure terminal is disposed', async () => {
Expand Down