Skip to content

Apply API recommendations for Create Env API #21804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Karthik Nadig (karthiknadig) merged 6 commits into from
Aug 15, 2023
Merged

Apply API recommendations for Create Env API #21804

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
629e7f4
Apply API recommendations for Create Env API
karthiknadig Aug 11, 2023
839aa36
Fix test
karthiknadig Aug 11, 2023
e5c984e
Fix typing
karthiknadig Aug 14, 2023
b8ff61f
Fix errors
karthiknadig Aug 14, 2023
1653e1b
Fix tests
karthiknadig Aug 14, 2023
dad9943
Mark APIs as readonly
karthiknadig Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
  • Loading branch information
@karthiknadig
karthiknadig committed Aug 15, 2023
commit 1653e1b8789c47c0053bea2900c33245613339e5
1 change: 0 additions & 1 deletion src/test/pythonEnvironments/creation/provider/condaCreationProvider.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,6 @@ suite('Conda Creation provider tests', () => {
assert.deepStrictEqual(await promise, {
path: 'new_environment',
workspaceFolder: workspace1,
error: undefined,
});
assert.isTrue(showErrorMessageWithLogsStub.notCalled);
});
Expand Down
2 changes: 0 additions & 2 deletions src/test/pythonEnvironments/creation/provider/venvCreationProvider.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,6 @@ suite('venv Creation provider tests', () => {
assert.deepStrictEqual(actual, {
path: 'new_environment',
workspaceFolder: workspace1,
action: undefined,
error: undefined,
});
interpreterQuickPick.verifyAll();
progressMock.verifyAll();
Expand Down