Skip to content

Add npm project for Python API #21631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kartik Raj (karrtikr) merged 13 commits into from
Jul 14, 2023
Merged

Add npm project for Python API #21631

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7a7a700
Add npm project for Python API
Jul 13, 2023
c09df3d
Exclude python-extension npm project when compiling
Jul 14, 2023
1312893
Move main out of api
Jul 14, 2023
67d51e7
Rename
Jul 14, 2023
80f2e4e
Rename folder
Jul 14, 2023
726d2ed
Add package-lock.json
Jul 14, 2023
e39f8fc
Never commit get-pip.py
Jul 14, 2023
54e150c
Rename api types file
Jul 14, 2023
3f29c15
Also trigger on PRs and push
Jul 14, 2023
eb11e16
Move linting to pr checks so we don't have to do it before publishing
Jul 14, 2023
c6f3e68
Remove xvfb step when building
Jul 14, 2023
c354b6c
Add gulp task to verify successful compilation of API
Jul 14, 2023
42b1b41
Ignore out directory when linting
Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add gulp task to verify successful compilation of API
  • Loading branch information
Kartik Raj
Kartik Raj committed Jul 14, 2023
commit c354b6c9acedc21ff4468a79b34344e7603f434b
18 changes: 17 additions & 1 deletion gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const tsProject = ts.createProject('./tsconfig.json', { typescript });

const isCI = process.env.TRAVIS === 'true' || process.env.TF_BUILD !== undefined;

gulp.task('compile', (done) => {
gulp.task('compileCore', (done) => {
let failed = false;
tsProject
.src()
Expand All @@ -39,6 +39,22 @@ gulp.task('compile', (done) => {
.on('finish', () => (failed ? done(new Error('TypeScript compilation errors')) : done()));
});

const apiTsProject = ts.createProject('./pythonExtensionApi/tsconfig.json', { typescript });

gulp.task('compileApi', (done) => {
let failed = false;
apiTsProject
.src()
.pipe(apiTsProject())
.on('error', () => {
failed = true;
})
.js.pipe(gulp.dest('./pythonExtensionApi/out'))
.on('finish', () => (failed ? done(new Error('TypeScript compilation errors')) : done()));
});

gulp.task('compile', gulp.series('compileCore', 'compileApi'));

gulp.task('precommit', (done) => run({ exitOnError: true, mode: 'staged' }, done));

gulp.task('output:clean', () => del(['coverage']));
Expand Down
2 changes: 1 addition & 1 deletion pythonExtensionApi/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ First we need to define a `package.json` for the extension that wants to use the
// Depend on the Python extension facade npm module to get easier API access to the
// core extension.
"dependencies": {
"@vscode/pythonExtensionApi": "..."
"@vscode/python-extension": "..."
},
}
```
Expand Down
8 changes: 4 additions & 4 deletions pythonExtensionApi/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
{
"compilerOptions": {
"composite": true,
"incremental": true,
"baseUrl": ".",
"paths": {
"*": ["types/*"]
},
"module": "commonjs",
"target": "es2018",
"outDir": "./out",
Expand All @@ -24,8 +25,7 @@
"noUnusedParameters": true,
"noFallthroughCasesInSwitch": true,
"resolveJsonModule": true,
"removeComments": true,
"tsBuildInfoFile": "./out/tsconfig.tsbuildInfo",
"removeComments": true
},
"exclude": [
"node_modules",
Expand Down